Skip to content

modify np.int with np.int64 #49967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2023
Merged

modify np.int with np.int64 #49967

merged 3 commits into from
Jan 31, 2023

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Jan 20, 2023

PR types

Others

PR changes

Others

Describe

modify np.int with np.int64

@paddle-bot
Copy link

paddle-bot bot commented Jan 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -59,7 +59,7 @@ def generate_depth(dims, batch):
},
"op_outputs": {"Out": ["output_data"]},
"op_attrs": dics[0],
"outputs_dtype": {"output_data": np.int},
"outputs_dtype": {"output_data": np.int64},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果能确定,代码里的np.int表示的就是np.int64,那就改成np.int64,否则就用np.int_。np.int_不会改变原行为。
建议改成np.int_吧。
8488bc4f8ffc037a4528a18fca75baec

@luotao1
Copy link
Contributor

luotao1 commented Jan 30, 2023

请解决下冲突

Copy link
Contributor

@dingjiaweiww dingjiaweiww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit e7deae2 into PaddlePaddle:develop Jan 31, 2023
pangengzheng pushed a commit to pangengzheng/Paddle that referenced this pull request Feb 2, 2023
* change int -> int64

* Update python/paddle/fluid/tests/unittests/ir/inference/test_trt_convert_one_hot.py
@Liyulingyue Liyulingyue deleted the np_int branch February 21, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants